Checkstyle Results

The following document contains the results of Checkstyle .

Summary

Files

net/sourceforge/mavenplugins/sourceforge/FTPBean.java

Error		Line
	Line does not match expected header line of 'SourceForge Maven plugin.'.	1
	Line has trailing spaces.	2
	First sentence should end with a period.	21
	Line is longer than 80 characters.	22
	Line has trailing spaces.	23
	'{' is not preceded with whitespace.	29
	Missing a Javadoc comment.	30
	Name '_site' must match pattern '^[a-z][a-zA-Z0-9]*$'.	30
	Missing a Javadoc comment.	31
	Name '_srcDir' must match pattern '^[a-z][a-zA-Z0-9]*$'.	31
	Missing a Javadoc comment.	32
	Name '_destDir' must match pattern '^[a-z][a-zA-Z0-9]*$'.	32
	Missing a Javadoc comment.	33
	Name '_userEmail' must match pattern '^[a-z][a-zA-Z0-9]*$'.	33
	First sentence should end with a period.	35
	Method 'getSite' is not designed for extension - needs to be abstract, final or empty.	46
	Method 'setSite' is not designed for extension - needs to be abstract, final or empty.	54
	Parameter site should be final.	54
	Method 'getDestDir' is not designed for extension - needs to be abstract, final or empty.	62
	Method 'setDestDir' is not designed for extension - needs to be abstract, final or empty.	70
	Parameter destDir should be final.	70
	Method 'getSrcDir' is not designed for extension - needs to be abstract, final or empty.	78
	Method 'setSrcDir' is not designed for extension - needs to be abstract, final or empty.	86
	Parameter srcDir should be final.	86
	Line has trailing spaces.	89
	Method 'getUserEmail' is not designed for extension - needs to be abstract, final or empty.	94
	Method 'setUserEmail' is not designed for extension - needs to be abstract, final or empty.	102
	Parameter userEmail should be final.	102
	Method 'execute' is not designed for extension - needs to be abstract, final or empty.	106
	Missing a Javadoc comment.	106
	Line has trailing spaces.	108
	Line is longer than 80 characters.	111
	Line is longer than 80 characters.	114
	Line is longer than 80 characters.	117
	Line is longer than 80 characters.	120
	Line has trailing spaces.	122
	Line is longer than 80 characters.	128
	Line has trailing spaces.	131
	Line has trailing spaces.	134
	Line has trailing spaces.	138
	Line has trailing spaces.	150
	Line is longer than 80 characters.	151
	'500' is a magic number.	153
	Must have at least one statement.	154
	Line has trailing spaces.	158
	Line has trailing spaces.	159
	'catch' is not followed by whitespace.	167
	Must have at least one statement.	167
	Line has trailing spaces.	173
	Line has trailing spaces.	174
	Line is longer than 80 characters.	177
	Method 'doTag' is not designed for extension - needs to be abstract, final or empty.	177
	Parameter out should be final.	177
	Redundant throws: 'MissingAttributeException' is subclass of 'JellyTagException'.	177
	Line has trailing spaces.	184
	Missing a Javadoc comment.	185
	Parameter ftp should be final.	185
	'if' is not followed by whitespace.	188

net/sourceforge/mavenplugins/sourceforge/FileReleaseSystemBean.java

Error		Line
	Line does not match expected header line of 'SourceForge Maven plugin.'.	1
	Line has trailing spaces.	2
	Line has trailing spaces.	32
	Missing a Javadoc comment.	40
	Missing a Javadoc comment.	43
	Name '_browser' must match pattern '^[a-z][a-zA-Z0-9]*$'.	43
	Missing a Javadoc comment.	44
	Name '_srcDir' must match pattern '^[a-z][a-zA-Z0-9]*$'.	44
	Missing a Javadoc comment.	45
	Name '_sfGroupId' must match pattern '^[a-z][a-zA-Z0-9]*$'.	45
	Missing a Javadoc comment.	46
	Name '_sfUserName' must match pattern '^[a-z][a-zA-Z0-9]*$'.	46
	Missing a Javadoc comment.	47
	Name '_sfPassword' must match pattern '^[a-z][a-zA-Z0-9]*$'.	47
	Missing a Javadoc comment.	48
	Name '_package' must match pattern '^[a-z][a-zA-Z0-9]*$'.	48
	Missing a Javadoc comment.	49
	Name '_release' must match pattern '^[a-z][a-zA-Z0-9]*$'.	49
	Missing a Javadoc comment.	50
	Name '_overwriteRelease' must match pattern '^[a-z][a-zA-Z0-9]*$'.	50
	Missing a Javadoc comment.	51
	Name '_changeLogFile' must match pattern '^[a-z][a-zA-Z0-9]*$'.	51
	Missing a Javadoc comment.	52
	Name '_releaseNotesFile' must match pattern '^[a-z][a-zA-Z0-9]*$'.	52
	Missing a Javadoc comment.	53
	Name '_proxyHost' must match pattern '^[a-z][a-zA-Z0-9]*$'.	53
	Missing a Javadoc comment.	54
	Name '_proxyPort' must match pattern '^[a-z][a-zA-Z0-9]*$'.	54
	Missing a Javadoc comment.	55
	Name '_proxyUserName' must match pattern '^[a-z][a-zA-Z0-9]*$'.	55
	Missing a Javadoc comment.	56
	Name '_proxyPassword' must match pattern '^[a-z][a-zA-Z0-9]*$'.	56
	Missing a Javadoc comment.	57
	Name '_proxyNTDomain' must match pattern '^[a-z][a-zA-Z0-9]*$'.	57
	Missing a Javadoc comment.	58
	Name '_submitNewsItem' must match pattern '^[a-z][a-zA-Z0-9]*$'.	58
	Missing a Javadoc comment.	59
	Name '_newsTitle' must match pattern '^[a-z][a-zA-Z0-9]*$'.	59
	Missing a Javadoc comment.	60
	Name '_projectName' must match pattern '^[a-z][a-zA-Z0-9]*$'.	60
	Missing a Javadoc comment.	61
	Name '_sendEmailNotice' must match pattern '^[a-z][a-zA-Z0-9]*$'.	61
	First sentence should end with a period.	63
	Method 'getSrcDir' is not designed for extension - needs to be abstract, final or empty.	75
	Method 'setSrcDir' is not designed for extension - needs to be abstract, final or empty.	83
	Parameter srcDir should be final.	83
	Line has trailing spaces.	86
	Method 'getSfGroupId' is not designed for extension - needs to be abstract, final or empty.	91
	Method 'setSfGroupId' is not designed for extension - needs to be abstract, final or empty.	99
	Parameter sfGroupId should be final.	99
	Method 'getSfUserName' is not designed for extension - needs to be abstract, final or empty.	107
	Method 'setSfUserName' is not designed for extension - needs to be abstract, final or empty.	115
	Parameter sfUserName should be final.	115
	Method 'getSfPassword' is not designed for extension - needs to be abstract, final or empty.	123
	Method 'setSfPassword' is not designed for extension - needs to be abstract, final or empty.	131
	Parameter sfPassword should be final.	131
	First sentence should end with a period.	135
	Method 'getProjectName' is not designed for extension - needs to be abstract, final or empty.	139
	Line has trailing spaces.	142
	First sentence should end with a period.	143
	Method 'setProjectName' is not designed for extension - needs to be abstract, final or empty.	147
	Parameter name should be final.	147
	Line has trailing spaces.	150
	Method 'getPackage' is not designed for extension - needs to be abstract, final or empty.	155
	Method 'setPackage' is not designed for extension - needs to be abstract, final or empty.	163
	Parameter package1 should be final.	163
	Method 'getRelease' is not designed for extension - needs to be abstract, final or empty.	171
	Method 'setRelease' is not designed for extension - needs to be abstract, final or empty.	179
	Parameter release should be final.	179
	Method 'isOverwriteExistingRelease' is not designed for extension - needs to be abstract, final or empty.	187
	Method 'setOverwriteExistingRelease' is not designed for extension - needs to be abstract, final or empty.	195
	Parameter overwrite should be final.	195
	Method 'getChangeLogFile' is not designed for extension - needs to be abstract, final or empty.	203
	Method 'setChangeLogFile' is not designed for extension - needs to be abstract, final or empty.	211
	Parameter changeLogFile should be final.	211
	Method 'getReleaseNotesFile' is not designed for extension - needs to be abstract, final or empty.	219
	Method 'setReleaseNotesFile' is not designed for extension - needs to be abstract, final or empty.	227
	Parameter releaseNotesFile should be final.	227
	Method 'isSubmitNewsItem' is not designed for extension - needs to be abstract, final or empty.	235
	Method 'setSendEmailNotice' is not designed for extension - needs to be abstract, final or empty.	243
	Parameter sendEmailNotice should be final.	243
	Method 'isSendEmailNotice' is not designed for extension - needs to be abstract, final or empty.	251
	Method 'setSubmitNewsItem' is not designed for extension - needs to be abstract, final or empty.	259
	Parameter submitNewsItem should be final.	259
	Method 'getNewsTitle' is not designed for extension - needs to be abstract, final or empty.	267
	Method 'setNewsTitle' is not designed for extension - needs to be abstract, final or empty.	275
	Parameter newsTitle should be final.	275
	Method 'getProxyHost' is not designed for extension - needs to be abstract, final or empty.	283
	Method 'setProxyHost' is not designed for extension - needs to be abstract, final or empty.	291
	Parameter proxyHost should be final.	291
	Method 'getProxyPort' is not designed for extension - needs to be abstract, final or empty.	299
	Method 'setProxyPort' is not designed for extension - needs to be abstract, final or empty.	307
	Parameter proxyPort should be final.	307
	Method 'getProxyUserName' is not designed for extension - needs to be abstract, final or empty.	315
	Method 'setProxyUserName' is not designed for extension - needs to be abstract, final or empty.	323
	Parameter proxyUserName should be final.	323
	Line has trailing spaces.	326
	Method 'getProxyPassword' is not designed for extension - needs to be abstract, final or empty.	331
	Method 'setProxyPassword' is not designed for extension - needs to be abstract, final or empty.	339
	Parameter proxyPassword should be final.	339
	Method 'getProxyNTDomain' is not designed for extension - needs to be abstract, final or empty.	347
	Method 'setProxyNTDomain' is not designed for extension - needs to be abstract, final or empty.	355
	Parameter proxyNTDomain should be final.	355
	Method 'execute' is not designed for extension - needs to be abstract, final or empty.	359
	Missing a Javadoc comment.	359
	Line has trailing spaces.	374
	Line is longer than 80 characters.	377
	Line is longer than 80 characters.	380
	Line is longer than 80 characters.	383
	Line is longer than 80 characters.	386
	Line is longer than 80 characters.	389
	Line has trailing spaces.	391
	Line is longer than 80 characters.	399
	Line has trailing spaces.	405
	Line is longer than 80 characters.	406
	Line is longer than 80 characters.	409
	Line has trailing spaces.	415
	Line is longer than 80 characters.	415
	Line is longer than 80 characters.	416
	Line is longer than 80 characters.	421
	Line has trailing spaces.	424
	Line is longer than 80 characters.	424
	Expression can be simplified.	431
	Line is longer than 80 characters.	432
	Line is longer than 80 characters.	436
	Line is longer than 80 characters.	449
	Line is longer than 80 characters.	451
	Line has trailing spaces.	453
	Line is longer than 80 characters.	457
	Line is longer than 80 characters.	463
	Line has trailing spaces.	470
	Line has trailing spaces.	471
	Line is longer than 80 characters.	474
	Method 'doTag' is not designed for extension - needs to be abstract, final or empty.	474
	Parameter out should be final.	474
	Redundant throws: 'MissingAttributeException' is subclass of 'JellyTagException'.	474
	Method 'login' is not designed for extension - needs to be abstract, final or empty.	482
	Missing a Javadoc comment.	482
	Line is longer than 80 characters.	483
	Line has trailing spaces.	485
	Line is longer than 80 characters.	486
	Line has trailing spaces.	492
	Line has trailing spaces.	494
	Line has trailing spaces.	496
	Line is longer than 80 characters.	496
	Method 'checkLoginResponse' is not designed for extension - needs to be abstract, final or empty.	501
	Missing a Javadoc comment.	501
	Parameter doc should be final.	501
	Line has trailing spaces.	505
	Line is longer than 80 characters.	506
	First sentence should end with a period.	516
	Method 'getGroupId' is not designed for extension - needs to be abstract, final or empty.	521
	Parameter doc should be final.	521
	Line is longer than 80 characters.	524
	Line is longer than 80 characters.	530
	Line is longer than 80 characters.	531
	Line has trailing spaces.	537
	Method 'isReleasePermissionDenied' is not designed for extension - needs to be abstract, final or empty.	542
	Parameter doc should be final.	542
	Line is longer than 80 characters.	545
	Line has trailing spaces.	548
	First sentence should end with a period.	549
	Method 'getPackageId' is not designed for extension - needs to be abstract, final or empty.	554
	Parameter doc should be final.	554
	Line is longer than 80 characters.	557
	Line is longer than 80 characters.	561
	Line is longer than 80 characters.	562
	Line is longer than 80 characters.	563
	Line is longer than 80 characters.	564
	Method 'canCreatePackage' is not designed for extension - needs to be abstract, final or empty.	575
	Parameter doc should be final.	575
	Line is longer than 80 characters.	578
	Line has trailing spaces.	581
	First sentence should end with a period.	582
	Method 'createPackage' is not designed for extension - needs to be abstract, final or empty.	586
	Expected @throws tag for 'Exception'.	586
	Line is longer than 80 characters.	588
	Line has trailing spaces.	594
	First sentence should end with a period.	599
	Method 'getReleaseId' is not designed for extension - needs to be abstract, final or empty.	604
	Parameter doc should be final.	604
	Line is longer than 80 characters.	607
	Line is longer than 80 characters.	624
	First sentence should end with a period.	631
	Method 'createRelease' is not designed for extension - needs to be abstract, final or empty.	635
	Parameter packageId should be final.	635
	Expected @param tag for 'packageId'.	635
	Expected @throws tag for 'Exception'.	635
	Line is longer than 80 characters.	636
	Line has trailing spaces.	637
	Line is longer than 80 characters.	637
	Line has trailing spaces.	640
	Line is longer than 80 characters.	641
	Line has trailing spaces.	649
	Line is longer than 80 characters.	653
	Method 'getCreatedReleaseId' is not designed for extension - needs to be abstract, final or empty.	653
	Missing a Javadoc comment.	653
	Parameter doc should be final.	653
	Redundant throws: 'NumberFormatException' is unchecked exception.	653
	Line is longer than 80 characters.	656
	Line is longer than 80 characters.	658
	First sentence should end with a period.	664
	Line has trailing spaces.	665
	Line has trailing spaces.	666
	Line is longer than 80 characters.	671
	Method 'uploadNotes' is not designed for extension - needs to be abstract, final or empty.	671
	Parameter packageId should be final.	671
	Parameter releaseId should be final.	671
	Expected @throws tag for 'Exception'.	671
	Line is longer than 80 characters.	672
	Line has trailing spaces.	689
	Line has trailing spaces.	694
	First sentence should end with a period.	695
	Line is longer than 80 characters.	701
	Method 'selectUploadedFiles' is not designed for extension - needs to be abstract, final or empty.	701
	Parameter packageId should be final.	701
	Parameter releaseId should be final.	701
	Expected @throws tag for 'Exception'.	701
	Line is longer than 80 characters.	702
	Line has trailing spaces.	717
	Line has trailing spaces.	722
	First sentence should end with a period.	723
	Method 'getFileId' is not designed for extension - needs to be abstract, final or empty.	729
	Parameter doc should be final.	729
	Parameter fileName should be final.	729
	Expected @throws tag for 'Exception'.	729
	Line is longer than 80 characters.	733
	Line is longer than 80 characters.	735
	Line is longer than 80 characters.	739
	Line has trailing spaces.	742
	First sentence should end with a period.	743
	Line is longer than 80 characters.	751
	Method 'defineFileInformation' is not designed for extension - needs to be abstract, final or empty.	751
	Parameter packageId should be final.	751
	Parameter releaseId should be final.	751
	Parameter fileId should be final.	751
	Parameter fileName should be final.	751
	Expected @throws tag for 'Exception'.	751
	Line is longer than 80 characters.	752
	Line has trailing spaces.	777
	First sentence should end with a period.	781
	Line is longer than 80 characters.	786
	Method 'sendEmailConfirmation' is not designed for extension - needs to be abstract, final or empty.	786
	Parameter packageId should be final.	786
	Parameter releaseId should be final.	786
	Expected @throws tag for 'URIException'.	786
	Line is longer than 80 characters.	788
	Line has trailing spaces.	795
	First sentence should end with a period.	800
	Method 'submitNewsItem' is not designed for extension - needs to be abstract, final or empty.	803
	Expected @throws tag for 'Exception'.	803
	Line is longer than 80 characters.	805
	Line has trailing spaces.	811
	Line has trailing spaces.	817
	Line is longer than 80 characters.	818
	Line has trailing spaces.	820
	Line is longer than 80 characters.	821
	Line is longer than 80 characters.	824
	Line is longer than 80 characters.	827

net/sourceforge/mavenplugins/sourceforge/WebBrowser.java

Error		Line
	Line does not match expected header line of 'SourceForge Maven plugin.'.	1
	Line has trailing spaces.	2
	First sentence should end with a period.	37
	Line has trailing spaces.	39
	Class WebBrowser should be declared as final.	45
	Line has trailing spaces.	46
	Line is longer than 80 characters.	49
	Line is longer than 80 characters.	50
	Line is longer than 80 characters.	51
	Line has trailing spaces.	53
	Missing a Javadoc comment.	54
	Name '_instance' must match pattern '^[a-z][a-zA-Z0-9]*$'.	54
	Line has trailing spaces.	55
	Missing a Javadoc comment.	56
	Name '_client' must match pattern '^[a-z][a-zA-Z0-9]*$'.	56
	Missing a Javadoc comment.	57
	Name '_parser' must match pattern '^[a-z][a-zA-Z0-9]*$'.	57
	Line has trailing spaces.	58
	Line has trailing spaces.	63
	Line has trailing spaces.	65
	Missing a Javadoc comment.	66
	Parameter s should be final.	66
	Line has trailing spaces.	72
	Missing a Javadoc comment.	73
	Parameter s should be final.	73
	'-' is not preceded with whitespace.	75
	'-' is not followed by whitespace.	75
	Line has trailing spaces.	79
	First sentence should end with a period.	80
	Line has trailing spaces.	86
	'443' is a magic number.	87
	Line is longer than 80 characters.	91
	First sentence should end with a period.	107
	Unused @param tag for 'proxyNTDomain'.	112
	Line is longer than 80 characters.	116
	Parameter proxyHost should be final.	116
	Parameter proxyPort should be final.	116
	Expected @param tag for 'ntDomain'.	116
	Parameter password should be final.	116
	Line is longer than 80 characters.	121
	Line is longer than 80 characters.	127
	Line has trailing spaces.	137
	First sentence should end with a period.	138
	Line has trailing spaces.	140
	Parameter method should be final.	144
	Expected @throws tag for 'URIException'.	144
	Line has trailing spaces.	147
	Line is longer than 80 characters.	148
	Line has trailing spaces.	149
	'3' is a magic number.	151
	Line is longer than 80 characters.	156
	Line has trailing spaces.	163
	Line is longer than 80 characters.	167
	Line has trailing spaces.	169
	'400' is a magic number.	170
	Line is longer than 80 characters.	172
	Line has trailing spaces.	174
	'300' is a magic number.	176
	'400' is a magic number.	176
	Line has trailing spaces.	181
	Line has trailing spaces.	184
	Line has trailing spaces.	185
	Line has trailing spaces.	186
	Line is longer than 80 characters.	191
	Line has trailing spaces.	196
	Line has trailing spaces.	198
	Line has trailing spaces.	202
	Line has trailing spaces.	204
	Line is longer than 80 characters.	207
	Line is longer than 80 characters.	208
	Line has trailing spaces.	214
	First sentence should end with a period.	218
	Line has trailing spaces.	220
	Expected an @return tag.	224
	Parameter method should be final.	224
	Expected @param tag for 'method'.	224
	Expected @throws tag for 'URIException'.	224
	Line has trailing spaces.	230
	Line has trailing spaces.	232
	Line has trailing spaces.	233
	Expected an @return tag.	237
	Parameter method should be final.	237
	Expected @param tag for 'method'.	237
	Expected @throws tag for 'Exception'.	237
	Line has trailing spaces.	239
	Line is longer than 80 characters.	240
	Line has trailing spaces.	241
	Line has trailing spaces.	243
	Line has trailing spaces.	245
	Missing a Javadoc comment.	248
	Parameter method should be final.	248
	Parameter destFile should be final.	248
	'8' is a magic number.	256
	'1024' is a magic number.	256
	Line has trailing spaces.	271

net/sourceforge/mavenplugins/sourceforge/package.html

Error		Line
	Missing package documentation file.	0

org/apache/commons/httpclient/contrib/ssl/EasySSLProtocolSocketFactory.java

Error		Line
	File does not end with a newline.	0

org/apache/commons/httpclient/contrib/ssl/EasySSLProtocolSocketFactory.java

Error		Line
	Line does not match expected header line of 'SourceForge Maven plugin.'.	1
	Line has trailing spaces.	69
	Line has trailing spaces.	72
	Line has trailing spaces.	77
	Line has trailing spaces.	78
	Line has trailing spaces.	81
	Line has trailing spaces.	82
	Line has trailing spaces.	83
	Line has trailing spaces.	86
	Line has trailing spaces.	88
	Line is longer than 80 characters.	94
	Line is longer than 80 characters.	97
	Line has trailing spaces.	101
	Line has trailing spaces.	103
	Line has trailing spaces.	105
	Missing a Javadoc comment.	116
	Line has trailing spaces.	121
	Line has trailing spaces.	122
	Line is longer than 80 characters.	133
	Method 'createSocket' is not designed for extension - needs to be abstract, final or empty.	135
	Parameter host should be final.	136
	Parameter port should be final.	137
	Parameter clientHost should be final.	138
	Parameter clientPort should be final.	139
	Redundant throws: 'UnknownHostException' is subclass of 'IOException'.	140
	Method 'createSocket' is not designed for extension - needs to be abstract, final or empty.	154
	Parameter host should be final.	154
	Parameter port should be final.	154
	Redundant throws: 'UnknownHostException' is subclass of 'IOException'.	155
	Line is longer than 80 characters.	163
	Method 'createSocket' is not designed for extension - needs to be abstract, final or empty.	165
	Parameter socket should be final.	166
	Parameter host should be final.	167
	Parameter port should be final.	168
	Parameter autoClose should be final.	169
	Redundant throws: 'UnknownHostException' is subclass of 'IOException'.	170

org/apache/commons/httpclient/contrib/ssl/EasyX509TrustManager.java

Error		Line
	File does not end with a newline.	0

org/apache/commons/httpclient/contrib/ssl/EasyX509TrustManager.java

Error		Line
	Line does not match expected header line of 'SourceForge Maven plugin.'.	1
	Line has trailing spaces.	71
	Line has trailing spaces.	76
	Line has trailing spaces.	77
	Line has trailing spaces.	80
	Line has trailing spaces.	81
	Line has trailing spaces.	82
	Line has trailing spaces.	85
	Line has trailing spaces.	88
	'{' should be on the previous line.	95
	Missing a Javadoc comment.	96
	Line is longer than 80 characters.	99
	Line is longer than 80 characters.	104
	Parameter keystore should be final.	104
	Expected @param tag for 'keystore'.	104
	Expected @throws tag for 'NoSuchAlgorithmException'.	104
	Expected @throws tag for 'KeyStoreException'.	104
	Line is longer than 80 characters.	106
	Line is longer than 80 characters.	110
	'cast' is not followed by whitespace.	112
	Method 'isClientTrusted' is not designed for extension - needs to be abstract, final or empty.	118
	Parameter certificates should be final.	118
	Method 'isServerTrusted' is not designed for extension - needs to be abstract, final or empty.	125
	Parameter certificates should be final.	125
	Line has trailing spaces.	135
	'}' should be on the same line.	136
	Method 'getAcceptedIssuers' is not designed for extension - needs to be abstract, final or empty.	150

org/apache/commons/httpclient/contrib/ssl/package.html

Error		Line
	Missing package documentation file.	0